cmake: fix libatomic check with GCC 8 #1243
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1199
Description of changes:
Fixes detection of libatomic with GCC 8. This solution is based on https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=907277#25, which describes why the error occurs (in that case with autotools).
Some of the possible solutions are:
enable_language(C)
so that the check runs in C mode (untested)__atomic_load_8
with the right number of argumentslibatomic
test altogether and just check whether C++ atomics work when linked tolibatomic
I chose option 2 because it maintained the existing semantics and seemed cleaner than using the C compiler to work around this issue.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.