service/dynamodb/expression: fix empty expression returned when unset #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasdel @skotambkar another small PR for you. This time a bug fix. ref #554 |
|
Bump @jasdel @skotambkar |
|
Hi @alextbok thanks for taking the time to create this PR. We'll review this and update the issue with feedback. From initial glance this looks good. DynamoDB recently made updates to their API to allow empty maps/lists/strings in their APIs. Will need to check and see if that impacts the Filter behavior as well. |
jasdel
approved these changes
Jun 1, 2020
jasdel
changed the title
skmcgrail
added a commit
to skmcgrail/aws-sdk-go-v2
that referenced
this pull request
Jul 21, 2020
=== Announcements --- * Since February 2020 the team for the AWS SDK for Go have been working to reimagine and modernize the SDK to take advantage of exciting new developments within AWS. We have been working towards supporting the [Smithy](https://awslabs.github.io/smithy) protocol agnostic modeling language. While implementing support we have taken the opportunity to make significant changes to our client interfaces, middleware, and configuration. * This release will mark the final release using the current SDK design. Over the next release we will be remove clients using the former design, and will be re-introduce clients over a number of follow-up releases as we add support for additional services as they are ready. * We encourage our community of users to provide feedback, bug reports, and feature requests via [Github Issues](https://github.com/aws/aws-sdk-go-v2/issues/new/choose) as we introduce the new clients and design over the next set of releases. Services --- * Synced the V2 SDK with latest AWS service API definitions. SDK Bugs --- * `service/dynamodb/expression: fix empty expression returned when unset ([aws#562](aws#562)) * Fixes a big in the expression builder that returns an empty string expression value when the expression has not been set. * Fixes [aws#554](aws#554)
skmcgrail
added a commit
to skmcgrail/aws-sdk-go-v2
that referenced
this pull request
Jul 21, 2020
Announcements --- * Since February 2020 the team for the AWS SDK for Go have been working to reimagine and modernize the SDK to take advantage of exciting new developments within AWS. We have been working towards supporting the [Smithy](https://awslabs.github.io/smithy) protocol agnostic modeling language. While implementing support we have taken the opportunity to make significant changes to our client interfaces, middleware, and configuration. * This release will mark the final release using the current SDK design. Starting with the next release we will remove clients using the former design, and will re-introduce clients in subsequent releases as we add support for their protocols and customizations. * We encourage our community of users to provide feedback, bug reports, and feature requests via [Github Issues](https://github.com/aws/aws-sdk-go-v2/issues/new/choose) as we introduce the new clients and design over the next set of releases. Services --- * Synced the V2 SDK with latest AWS service API definitions. SDK Bugs --- * `service/dynamodb/expression: fix empty expression returned when unset ([aws#562](aws#562)) * Fixes a big in the expression builder that returns an empty string expression value when the expression has not been set. * Fixes [aws#554](aws#554)
skmcgrail
added a commit
that referenced
this pull request
Jul 22, 2020
Announcements --- * Since February 2020 the team for the AWS SDK for Go have been working to reimagine and modernize the SDK to take advantage of exciting new developments within AWS. We have been working towards supporting the [Smithy](https://awslabs.github.io/smithy) protocol agnostic modeling language. While implementing support we have taken the opportunity to make significant changes to our client interfaces, middleware, and configuration. * This release will mark the final release using the current SDK design. Starting with the next release we will remove clients using the former design, and will re-introduce clients in subsequent releases as we add support for their protocols and customizations. * We encourage our community of users to provide feedback, bug reports, and feature requests via [Github Issues](https://github.com/aws/aws-sdk-go-v2/issues/new/choose) as we introduce the new clients and design over the next set of releases. Services --- * Synced the V2 SDK with latest AWS service API definitions. SDK Bugs --- * `service/dynamodb/expression: fix empty expression returned when unset ([#562](#562)) * Fixes a big in the expression builder that returns an empty string expression value when the expression has not been set. * Fixes [#554](#554)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a big in the expression builder that returns an empty string expression value when the expression has not been set.
Fixes #554