Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUnit 5] Migrate some parameterized tests to JUnit 5 #2880

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

Bennett-Lynch
Copy link
Contributor

JUnit 4 -> 5 migrations are often done in a 3-step process:

  1. Update dependencies to JUnit 5, including the vintage module, causing all tests to leverage the new JUnit 5 Platform
  2. Incrementally migrate JUnit 4 tests to JUnit 5 tests
  3. Once no JUnit 4 usage remains, remove the dependency on the vintage module

This PR continues step 2 by migrating some parameterized tests to JUnit 5.

License

  • I confirm that this pull request can be released under the Apache 2 license

JUnit 4 -> 5 migrations are often done in a 3-step process:

1. Update dependencies to JUnit 5, including the vintage module,
causing all tests to leverage the new JUnit 5 Platform
2. Incrementally migrate JUnit 4 tests to JUnit 5 tests
3. Once no JUnit 4 usage remains, remove the dependency on the
vintage module

This PR continues step 2 by migrating some parameterized tests to JUnit
5.
@Bennett-Lynch Bennett-Lynch requested a review from a team as a code owner December 2, 2021 18:25
Copy link
Contributor

@cenedhryn cenedhryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new API is more intuitive IMO!

@sonarcloud
Copy link

sonarcloud bot commented Dec 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2995 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Bennett-Lynch Bennett-Lynch merged commit e2915d0 into aws:master Dec 3, 2021
aws-sdk-java-automation pushed a commit that referenced this pull request Dec 3, 2021
Revert "[JUnit 5] Migrate some parameterized tests to JUnit 5 (#2880)"
aws-sdk-java-automation added a commit that referenced this pull request Jan 31, 2024
…a131f31e5

Pull request: release <- staging/590b85ab-f197-473d-a0c3-616a131f31e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants