Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement defaults mode #2909

Merged
merged 13 commits into from
Dec 17, 2021
Merged

Implement defaults mode #2909

merged 13 commits into from
Dec 17, 2021

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Dec 10, 2021

Description

Introduce a defaults mode configuration that determines how certain default configuration options are resolved in the SDK

Testing

Added unit tests and functional tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

* Implement auto mode discovery

* Fix tests on CodeBuild

* Address feedback

* Add comment and rename misnamed constant
…e configuration resolution chain (#2803)

* Wiring up configuration

* Address comments

* Add test

* Update debug statement and add singleton for AttributeMap
…asses to aws-core (#2816)

* Move default configuration related classes to aws-core

* Remove extra space and fix build
…etting (#2825)

* Add s3 regional setting

* Rename option name
@zoewangg zoewangg marked this pull request as ready for review December 15, 2021 21:53
@zoewangg zoewangg requested a review from a team as a code owner December 15, 2021 21:53
@sonarcloud
Copy link

sonarcloud bot commented Dec 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

91.2% 91.2% Coverage
0.0% 0.0% Duplication

@zoewangg zoewangg merged commit ee9ea08 into master Dec 17, 2021
@zoewangg zoewangg deleted the feature/master/defaults-mode branch February 15, 2022 22:13
@zoewangg zoewangg restored the feature/master/defaults-mode branch February 15, 2022 22:14
@zoewangg zoewangg deleted the feature/master/defaults-mode branch February 15, 2022 22:14
aws-sdk-java-automation added a commit that referenced this pull request Feb 27, 2024
…45e1b6492

Pull request: release <- staging/d5590a20-fdb4-4c31-87db-06445e1b6492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants