Support Customization string array endpoint params for S3 access grants, until all SDKs add support for string array. #5137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…params because S3 Access grants will not update the models until all sdks support stringarray endpoint params
joviegas
force-pushed
the
joviegas/Customization_stringarray
branch
from
b6b7037
to
2942f8b
Compare
cenedhryn
reviewed
Apr 23, 2024
| "endpointParameters": { | ||
| "endpointId": { | ||
| "required": false, | ||
| "documentation": "Test to make sure exceptiion is thrown when there is already a paramater defined in model.", |
There was a problem hiding this comment.
Nit: exceptiion an extra i
zoewangg
approved these changes
Apr 23, 2024
joviegas
merged commit 7886aaf
into
feature/StringArrayEndpointParams
7 of 8 checks passed
|
cenedhryn
reviewed
Apr 24, 2024
| @@ -843,4 +850,12 @@ public void setUseMultiAuth(boolean useMultiAuth) { | |||
| public boolean useMultiAuth() { | |||
| return useMultiAuth; | |||
| } | |||
|
|
|||
| public Map<String, ParameterModel> getEndpointParameters() { | |||
There was a problem hiding this comment.
I'm not sure if this definition is enough as a criteria for triggering codegen of the JMESPath runtime helper. Endpoint parameters could in the future be present in the customization config without the need for that, since it's only operation context params with nested types that needs it. The ParameterModel does not currently contain information that lets you decide that either, but maybe when adding operation context params that can fit into ParameterModel.
cenedhryn
added a commit
that referenced
this pull request
May 13, 2024
* feat(StringArrayEndpointParams) Codegen String Array Enpoint params and Auth schemes params based on end-point-rule-set.json. (#5122) * Support Customization string array endpoint params for S3 access grants, until all SDKs add support for string array. (#5137) * new(StringArrayEndpointParams) Codegeneration of OperationContextParams defined for a Operation. (#5146) * Extracting existing JMESPath runtime to a separate class (#5155) * new(StringArrayEndpointParams) Customization of Operation Context params and adding customizations for S3 (#5159) * Converts endpoint param list of string to list of value (#5169) * Generates JmesPath expressions for operation context parameters (#5172) * Supporting wildcard and keys fn in JmesPathRuntime (#5198) * Adds functional tests for list of string auth params (#5216) * Changelog --------- Co-authored-by: John Viegas <70235430+joviegas@users.noreply.github.com> Co-authored-by: John Viegas <joviegas@amazon.com>
akidambisrinivasan
pushed a commit
to akidambisrinivasan/aws-sdk-java-v2
that referenced
this pull request
Jun 28, 2024
* feat(StringArrayEndpointParams) Codegen String Array Enpoint params and Auth schemes params based on end-point-rule-set.json. (aws#5122) * Support Customization string array endpoint params for S3 access grants, until all SDKs add support for string array. (aws#5137) * new(StringArrayEndpointParams) Codegeneration of OperationContextParams defined for a Operation. (aws#5146) * Extracting existing JMESPath runtime to a separate class (aws#5155) * new(StringArrayEndpointParams) Customization of Operation Context params and adding customizations for S3 (aws#5159) * Converts endpoint param list of string to list of value (aws#5169) * Generates JmesPath expressions for operation context parameters (aws#5172) * Supporting wildcard and keys fn in JmesPathRuntime (aws#5198) * Adds functional tests for list of string auth params (aws#5216) * Changelog --------- Co-authored-by: John Viegas <70235430+joviegas@users.noreply.github.com> Co-authored-by: John Viegas <joviegas@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Customization string array endpoint params for S3 access grants, until all SDKs add support for string array.
Motivation and Context
Modifications
Testing
Screenshots (if appropriate)
Types of changes
License