new(StringArrayEndpointParams) Codegeneration of OperationContextParams defined for a Operation.

[joviegas]

Codegeneration of OperationContextParams defined for a Operation.

Note : After JMesPathRuntime implementation , the JMESPath parsing of List will be added. For now I have added a TODO as a place holder.

Motivation and Context

Modifications

• Added codegen in EndpointResolverInterceptorSpec to generate code for binding of OperationContext Params to StringArray Endpoint params

Testing

• Junit test cases
• Below is code Generated for S3ResolveEndpointInterceptor
• Junit added with a List structure similar to DeleteObjects Keys

    "DeleteObjects":{
      "name":"DeleteObjects",
      "http":{
        "method":"POST",
        "requestUri":"/{Bucket}?delete"
      },
      "input":{"shape":"DeleteObjectsRequest"},
      "output":{"shape":"DeleteObjectsOutput"},
      "documentationUrl":"http://docs.amazonwebservices.com/AmazonS3/latest/API/multiobjectdeleteapi.html",
      "alias":"DeleteMultipleObjects",
      "operationContextParams":{
        "DeleteObjectKeys":{"value":"Delete.Objects[*].Key"}
      },
      "httpChecksum":{
        "requestAlgorithmMember":"ChecksumAlgorithm",
        "requestChecksumRequired":true
      }
    },

public final class S3ResolveEndpointInterceptor implements ExecutionInterceptor {

    public static S3EndpointParams ruleParams(SdkRequest request, ExecutionAttributes executionAttributes) {
        S3EndpointParams.Builder builder = S3EndpointParams.builder();
// Existing code
        setStaticContextParams(builder, executionAttributes.getAttribute(AwsExecutionAttribute.OPERATION_NAME));
        setOperationContextParams(builder, executionAttributes.getAttribute(AwsExecutionAttribute.OPERATION_NAME), request);
        return builder.build();
    }

    private static void setOperationContextParams(S3EndpointParams.Builder params, String operationName, SdkRequest request) {
        switch (operationName) {
        case "DeleteObjects":
            setOperationContextParams(params, (DeleteObjectsRequest) request);
            break;
        default:
            break;
        }
    }

    private static void setOperationContextParams(S3EndpointParams.Builder params, DeleteObjectsRequest request) {
        // TODO: Add JMESPathRuntime for Delete.Objects[*].Key
        params.deleteObjectKeys(new ArrayList<>());
    }



}

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[millems]

LGTM, just some minor nits.

[millems]

CollectionUtils.isNotEmpty(opModel.getOperationContextParams())?

[millems]

I feel like people could make this mistake. Can we be more useful in the error message? Something like... "Invalid operation context parameter path for {operation-name}. Expected VALUE_STRING, but got {actual-value-type}".

[sonarcloud]

Quality Gate failed

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud