Converts endpoint param list of string to list of value #5169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rules engine can handle it
dagnir
reviewed
Apr 30, 2024
| @@ -147,6 +147,10 @@ public CodeBlock valueCreationCode(String type, CodeBlock param) { | |||
| break; | |||
| case "stringarray": | |||
| methodName = "fromArray"; | |||
| param = CodeBlock.of("$L.stream().map($T::fromStr).collect($T.toList())", | |||
There was a problem hiding this comment.
minor: use $N.stream() instead of $L, since $N is used for identifiers
dagnir
approved these changes
Apr 30, 2024
cenedhryn
merged commit ffb1cfa
into
feature/StringArrayEndpointParams
1 of 16 checks passed
|
cenedhryn
added a commit
that referenced
this pull request
May 13, 2024
* feat(StringArrayEndpointParams) Codegen String Array Enpoint params and Auth schemes params based on end-point-rule-set.json. (#5122) * Support Customization string array endpoint params for S3 access grants, until all SDKs add support for string array. (#5137) * new(StringArrayEndpointParams) Codegeneration of OperationContextParams defined for a Operation. (#5146) * Extracting existing JMESPath runtime to a separate class (#5155) * new(StringArrayEndpointParams) Customization of Operation Context params and adding customizations for S3 (#5159) * Converts endpoint param list of string to list of value (#5169) * Generates JmesPath expressions for operation context parameters (#5172) * Supporting wildcard and keys fn in JmesPathRuntime (#5198) * Adds functional tests for list of string auth params (#5216) * Changelog --------- Co-authored-by: John Viegas <70235430+joviegas@users.noreply.github.com> Co-authored-by: John Viegas <joviegas@amazon.com>
akidambisrinivasan
pushed a commit
to akidambisrinivasan/aws-sdk-java-v2
that referenced
this pull request
Jun 28, 2024
* feat(StringArrayEndpointParams) Codegen String Array Enpoint params and Auth schemes params based on end-point-rule-set.json. (aws#5122) * Support Customization string array endpoint params for S3 access grants, until all SDKs add support for string array. (aws#5137) * new(StringArrayEndpointParams) Codegeneration of OperationContextParams defined for a Operation. (aws#5146) * Extracting existing JMESPath runtime to a separate class (aws#5155) * new(StringArrayEndpointParams) Customization of Operation Context params and adding customizations for S3 (aws#5159) * Converts endpoint param list of string to list of value (aws#5169) * Generates JmesPath expressions for operation context parameters (aws#5172) * Supporting wildcard and keys fn in JmesPathRuntime (aws#5198) * Adds functional tests for list of string auth params (aws#5216) * Changelog --------- Co-authored-by: John Viegas <70235430+joviegas@users.noreply.github.com> Co-authored-by: John Viegas <joviegas@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The type of the endpoint param,
List<String>, and the type required by the rules engine,List<Value>, are incompatible. Codegen Generated Classes Test cannot compile.Modifications
StringusingValue.fromStrstringarraytoParameterType- required for Codegen Generated Classes Test tests to compile