Generates JmesPath expressions for operation context parameters #5172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cenedhryn
commented
May 1, 2024
| assertThat(new Value(singletonList("a")).length()).isEqualTo(new Value(1)); | ||
| } | ||
|
|
||
| // @Test |
There was a problem hiding this comment.
I just saw this - will need it for next PR
cenedhryn
commented
May 1, 2024
| import software.amazon.awssdk.services.restjsonwithwaiters.jmespath.internal.JmesPathRuntime.Value; | ||
| import software.amazon.awssdk.utils.Pair; | ||
|
|
||
| class JmesPathRuntimeValueTest { |
There was a problem hiding this comment.
Probably should not have renamed this class, but here we are. There is nothing removed.
zoewangg
reviewed
May 2, 2024
| case "stringarray": | ||
| return CodeBlock.of(".stringValues()"); | ||
| default: | ||
| return CodeBlock.of(""); |
There was a problem hiding this comment.
Should we throw UnsupportedOperationException?
There was a problem hiding this comment.
Yes, I think that's better. Good suggestion.
| case BOOLEAN: | ||
| return booleanValue.toString(); | ||
| default: | ||
| throw new IllegalStateException(); |
There was a problem hiding this comment.
Can we add more information in the exception even though it's unlikely to happen?
zoewangg
approved these changes
May 2, 2024
cenedhryn
merged commit f9724c3
into
feature/StringArrayEndpointParams
6 of 16 checks passed
cenedhryn
added a commit
that referenced
this pull request
May 13, 2024
* feat(StringArrayEndpointParams) Codegen String Array Enpoint params and Auth schemes params based on end-point-rule-set.json. (#5122) * Support Customization string array endpoint params for S3 access grants, until all SDKs add support for string array. (#5137) * new(StringArrayEndpointParams) Codegeneration of OperationContextParams defined for a Operation. (#5146) * Extracting existing JMESPath runtime to a separate class (#5155) * new(StringArrayEndpointParams) Customization of Operation Context params and adding customizations for S3 (#5159) * Converts endpoint param list of string to list of value (#5169) * Generates JmesPath expressions for operation context parameters (#5172) * Supporting wildcard and keys fn in JmesPathRuntime (#5198) * Adds functional tests for list of string auth params (#5216) * Changelog --------- Co-authored-by: John Viegas <70235430+joviegas@users.noreply.github.com> Co-authored-by: John Viegas <joviegas@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Endpoint parameters of type
stringarrayare supported for operation level traits only, normally via theOperationContextParamtrait, which uses a JmesPath expression to find and potentially transform a part of anSdkPojoin order to create a corresponding endpoint parameterModifications
wildcardand thekeysfunction. This means that the codegen side supports it, but the capability is lacking at runtime (future PR).Testing
codegen-generated-classes-testhas a new test class that evaluates that the value of the OperationContextParams are set correctly. The test cases contain the minimal subset of JmesPath that is required for OperationContextParams and already exists in the codebase: