-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows users to configure contentType for BlockingInputStreamAsyncRequestBody #5234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaykin
force-pushed
the
master
branch
2 times, most recently
from
May 28, 2024 03:49
765926f
to
50a1822
Compare
davidh44
reviewed
Jun 3, 2024
Thanks for the PR! Can we update the changelog and add tests as well? |
I'm not sure what kind of tests must be here... |
Look good, thanks! Updated the tests, triggering CI checks |
@all-contributors please add @chaykin for code |
I've put up a pull request to add @chaykin! 🎉 |
davidh44
approved these changes
Jun 5, 2024
Quality Gate passedIssues Measures |
2 tasks
akidambisrinivasan
pushed a commit
to akidambisrinivasan/aws-sdk-java-v2
that referenced
this pull request
Jun 28, 2024
…uestBody (aws#5234) * Allows users to configure contentType for BlockingInputStreamAsyncRequestBody (aws#5143) * Run new-change (aws#5143) * Add tests for BlockingInputStreamAsyncRequestBody (aws#5143) * Update tests --------- Co-authored-by: Kirill Chaykin <k.chaykin@metamodel.ru> Co-authored-by: hdavidh <hdavidh@amazon.com> Co-authored-by: David Ho <70000000+davidh44@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Implementation a feature, #5143 described
Modifications
Added method
BlockingInputStreamAsyncRequestBody.Builder#contentType
Testing
Modifications does not affect any tests
Types of changes
It is only exposing the ability to set a value. Change is backward compatible and does not change the functionality of any existing code
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License