fix(CopySourceRequestInS3): Updated codegen to customize the request before calling service

[joviegas]

Updated codegen to customize the request before sending, instead of using interceptors. This change ensures that customized parameters are available for EndpointResolveInterceptors during execution.

Motivation and Context

• In AWS SDK Java 2.x, the “copySource” API provided by model in CopyObjectRequest is deprecated.
• It has been replaced with "sourceBucket," "sourceKey," and "sourceVersionId" via customization.
• Recently, S3 wants “copySource” to be included in the Endpoint Params by adding in endpoint-ruleset.json
• Since "copySource" is deprecated, the new parameters "sourceBucket," "sourceKey," and "sourceVersionId" are used to update the request.
• The current binding of Endpoint Parameters from Request Parameters via the EndpointResolverInterceptors does not copy the customized values.
• The current CopySourceInterceptor copies over CopySource during the modifyRequest , but we need these to be updated in. 'beforeExecution` of EndpointResolverInterceptors

Modifications

• Add customization to transform Custom Request

  "preClientExecutionRequestCustomizer": {
    "OperationWithCustomMember": {
      "methodName": "dummyRequestModifier",
      "className": "software.amazon.awssdk.codegen.internal.UtilsTest"
    }
  }

Will result in

    @Override
    public CompletableFuture<OperationWithCustomMemberResponse> operationWithCustomMember(
        OperationWithCustomMemberRequest operationWithCustomMemberRequest) {
        // New single line generated from above customization
        operationWithCustomMemberRequest = UtilsTest.dummyRequestModifier(operationWithCustomMemberRequest);
        SdkClientConfiguration clientConfiguration = updateSdkClientConfiguration(operationWithCustomMemberRequest,
        // Existing Code
  

}

Testing

• Added Junits
• Already Integ test were present and these passed

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

License

• I confirm that this pull request can be released under the Apache 2 license

[L-Applin]

It would be good to keep a reference to CopySource in this class name, CopySourceModifierUtils maybe?

[joviegas]

I updated the name as CustomRequestTransformerUtils since in future if we need to do similar customization to any API then we can just add an API in this class.
Thus this class will have broader scope of all the RequestTransformer rather than just CopySource

[L-Applin]

Oh you were thinking of reusing this class for other things. I see. Would it be better to keep this class only for CopySource purpose or not?

[joviegas]

I was thinking of using this class to hold the static APIs that do the requests transformations via customization.
In this case we have two API copyObject and UploadPartCopy.
Since this utils is created to hold the CustomRequestTransformers thart will be used in Customizations I was thinking to keep its scope at this level rather than CopySource which is just a Field which gets transformed.

[L-Applin]

nit: I would drop the map suffix (everything is a map in json), simply customRequestTransformers sounds more clear to me. Other keys, like customOperationContextParams don't have the map suffix, it would make the customization file more consistent. But it is not a blocker for me.

[L-Applin]

Oh you were thinking of reusing this class for other things. I see. Would it be better to keep this class only for CopySource purpose or not?

[sonarcloud]

Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud