-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: remove
.promise()
calls from class member clients (#181)
- Loading branch information
Showing
7 changed files
with
132 additions
and
35 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"aws-sdk-js-codemod": patch | ||
--- | ||
|
||
Remove .promise() calls from class member clients |
18 changes: 18 additions & 0 deletions
18
src/transforms/v2-to-v3/__fixtures__/api-promise-class-member.input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
import * as AWS from 'aws-sdk'; | ||
|
||
export class SecretsManager { | ||
constructor(client = new AWS.SecretsManager()) { | ||
this.client = client; | ||
} | ||
|
||
async getSecretValue(secretId) { | ||
const response = await this.client | ||
.getSecretValue({ SecretId: secretId }) | ||
.promise(); | ||
if (response.SecretString) { | ||
return response.SecretString; | ||
} else { | ||
throw new Error(`Unable to get the secret value from ${secretId}`); | ||
} | ||
} | ||
} |
17 changes: 17 additions & 0 deletions
17
src/transforms/v2-to-v3/__fixtures__/api-promise-class-member.output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import { SecretsManager } from "@aws-sdk/client-secrets-manager"; | ||
|
||
export class SecretsManager { | ||
constructor(client = new SecretsManager()) { | ||
this.client = client; | ||
} | ||
|
||
async getSecretValue(secretId) { | ||
const response = await this.client | ||
.getSecretValue({ SecretId: secretId }); | ||
if (response.SecretString) { | ||
return response.SecretString; | ||
} else { | ||
throw new Error(`Unable to get the secret value from ${secretId}`); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
src/transforms/v2-to-v3/utils/getV2ClientIdThisExpressions.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
import { Collection, Identifier, JSCodeshift, MemberExpression, ThisExpression } from "jscodeshift"; | ||
|
||
export interface ThisMemberExpression { | ||
type: "MemberExpression"; | ||
object: ThisExpression; | ||
property: Identifier; | ||
} | ||
|
||
const thisMemberExpression = { type: "MemberExpression", object: { type: "ThisExpression" } }; | ||
|
||
export const getV2ClientIdThisExpressions = ( | ||
j: JSCodeshift, | ||
source: Collection<unknown>, | ||
v2ClientIdentifiers: Identifier[] | ||
): ThisMemberExpression[] => | ||
v2ClientIdentifiers.flatMap((v2ClientIdentifier) => | ||
source | ||
.find(j.AssignmentExpression, { | ||
left: thisMemberExpression as MemberExpression, | ||
right: v2ClientIdentifier, | ||
}) | ||
.nodes() | ||
.map( | ||
(assignmentExpression) => | ||
({ | ||
...thisMemberExpression, | ||
property: { | ||
type: "Identifier", | ||
name: ((assignmentExpression.left as MemberExpression).property as Identifier).name, | ||
}, | ||
} as ThisMemberExpression) | ||
) | ||
); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters