Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(smithy-client): add no-op logger #4172

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 11, 2022

Issue

internal JS-3687 and #4113

Added a no-op logger implementation to be used as default in clients.

@kuhe kuhe requested a review from a team as a code owner November 11, 2022 17:16
@kuhe kuhe merged commit d1774f3 into aws:main Nov 11, 2022
@kuhe kuhe deleted the feat/no-op-logger branch November 11, 2022 17:17
kuhe added a commit to kuhe/aws-sdk-js-v3 that referenced this pull request Nov 11, 2022
@trivikr trivikr changed the title fix(clients): use default no-op logger to preserve type safety chore(smithy-client): add no-op logger Nov 11, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants