Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): deserialization of jsonName complex shapes #4670

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Apr 26, 2023

Issue

#4653

Reference: #4657

Description

The generated string for one deserialization case (JsonName-having fields that deserialized container shapes) was incorrect.

Testing

  • protocol tests (though unfortunately they did not catch this issue)
  • integration tests
  • cucumber tests

Notes

There is a testing gap here since compilation checks, unit, integration, and protocol tests did not catch this issue.
The mistaken generated type coincidentally fit the signature of the function call it sits in.

The object can be a Record having values that are either triplets or functions.

{
  A: (_) => _ // function, OK
  B: [,(_) => _,] // triplet with middle value being a function, OK
  C: (_) => [,,] // incorrect generated syntax, but accepted as function
}

@kuhe kuhe requested a review from a team as a code owner April 26, 2023 20:42
@trivikr trivikr changed the title fix(codegen): fix codegen of jsonName complex shapes fix(clients): deserialization of jsonName complex shapes Apr 26, 2023
@trivikr trivikr merged commit d79d141 into aws:main Apr 26, 2023
@kuhe kuhe deleted the fix/jsonName-deser branch April 26, 2023 21:55
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants