fix(clients): deserialization of jsonName complex shapes #4670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#4653
Reference: #4657
Description
The generated string for one deserialization case (JsonName-having fields that deserialized container shapes) was incorrect.
Testing
Notes
There is a testing gap here since compilation checks, unit, integration, and protocol tests did not catch this issue.
The mistaken generated type coincidentally fit the signature of the function call it sits in.
The object can be a Record having values that are either triplets or functions.