Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: codegen for fixing streaming member shape #968

Merged

Conversation

AllanZhengYP
Copy link
Contributor

@AllanZhengYP AllanZhengYP commented Mar 2, 2020

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

codecov-io commented Mar 3, 2020

Codecov Report

Merging #968 into smithy-codegen will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           smithy-codegen     #968   +/-   ##
===============================================
  Coverage           91.36%   91.36%           
===============================================
  Files                 144      144           
  Lines                2837     2837           
  Branches              501      501           
===============================================
  Hits                 2592     2592           
  Misses                245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6af32...7cf728d. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AllanZhengYP added a commit to AllanZhengYP/aws-sdk-js-v3 that referenced this pull request Mar 5, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138)
* Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
AllanZhengYP added a commit to AllanZhengYP/aws-sdk-js-v3 that referenced this pull request Mar 5, 2020
* Protocol codegen fixes via protocol tests (awslabls/smithy-typescript#141)
* Update streaming member types(smithy-lang/smithy-typescript#138)
* Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
* Protocol codegen fixes via protocol tests (awslabls/smithy-typescript#141)
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AllanZhengYP AllanZhengYP merged commit 15a66c7 into aws:smithy-codegen Mar 5, 2020
AllanZhengYP added a commit that referenced this pull request Mar 5, 2020
* Update streaming member types(smithy-lang/smithy-typescript#138)
* Fix streaming type types when they are required(smithy-lang/smithy-typescript#140)
@lock
Copy link

lock bot commented Mar 17, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants