Cast string bodies to buffers to ensure correct encoding used #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisradek
suggested changes
Jan 17, 2017
| @@ -100,6 +100,9 @@ AWS.NodeHttpClient = AWS.util.inherit({ | |||
| total: totalBytes | |||
| }); | |||
| }); | |||
| if (typeof body === 'string') { | |||
| body = new Buffer(body); | |||
There was a problem hiding this comment.
Since the Buffer constructors are deprecated, we might want to add some feature detection to try Buffer.from first, then new Buffer.
|
Also, can you add a changelog entry using the |
1 similar comment
demobox
reviewed
Jan 18, 2017
| @@ -100,6 +100,10 @@ AWS.NodeHttpClient = AWS.util.inherit({ | |||
| total: totalBytes | |||
| }); | |||
| }); | |||
| if (typeof body === 'string') { | |||
| body = typeof Buffer.from === 'function' ? | |||
There was a problem hiding this comment.
This unfortunately is broken on Node 4.4.5 :-( Buffer.from is a function but fails (because it is actually Uint8Array.from)
root@45d8cedbf66f:/app# node --version
v4.4.5
root@45d8cedbf66f:/app# node
> Buffer.from === Uint8Array.from
true
> typeof Buffer.from
'function'
> Buffer.from("foo")
TypeError: this is not a typed array.
at Function.from (native)
...
This was referenced Jan 19, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that bodies are always converted to byte buffers before being passed to an
http.ClientRequest. It looks like the code that packs headers and short bodies into the same outgoing HTTP packet has a slightly different codepath for non-binary strings, which this change lets the SDK avoid.Resolves #1297.