-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TypeScript] Add endpoint property to AWS.S3 instances #1345
Conversation
2 similar comments
@RLovelett In this case, all services should expose the From a testing perspective, I think you can do you could do something like below in import {Endpoint} from '../lib/endpoint';
/* existing code */
var endpoint: Endpoint = s3.endpoint; |
The documentation for AWS.S3 states that it exposes a property, endpoint, which is an AWS.Endpoint object. However, the declaration for AWS.S3 does not expose the property. This patch resolves that issue.
@chrisradek thank you for the review! I have made the changes you've requested. |
@RLovelett |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
The documentation for
AWS.S3
states that it exposes a property,endpoint
, which is anAWS.Endpoint
object.However, the declaration for
AWS.S3
does not expose the property.This patch resolves that issue.
I tried to copy all the things I did for #1339.