Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript] Add endpoint property to AWS.S3 instances #1345

Merged
merged 1 commit into from
Feb 8, 2017
Merged

[TypeScript] Add endpoint property to AWS.S3 instances #1345

merged 1 commit into from
Feb 8, 2017

Conversation

RLovelett
Copy link
Contributor

The documentation for AWS.S3 states that it exposes a property, endpoint, which is an AWS.Endpoint object.

However, the declaration for AWS.S3 does not expose the property.

This patch resolves that issue.

I tried to copy all the things I did for #1339.

@coveralls
Copy link

coveralls commented Feb 6, 2017

Coverage Status

Coverage remained the same at 91.863% when pulling bf8885e on RLovelett:bugfix/s3-without-endpoint into 0642da0 on aws:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.863% when pulling bf8885e on RLovelett:bugfix/s3-without-endpoint into 0642da0 on aws:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.863% when pulling bf8885e on RLovelett:bugfix/s3-without-endpoint into 0642da0 on aws:master.

@chrisradek
Copy link
Contributor

chrisradek commented Feb 6, 2017

@RLovelett
Thanks again for your PR!
The typings in the clients folder are all auto-generated with each release, so can't be modified directly.

In this case, all services should expose the endpoint parameter. Since each service client extends Service, you could add endpoint: Endpoint there:
https://github.com/aws/aws-sdk-js/blob/master/lib/service.d.ts

From a testing perspective, I think you can do you could do something like below in ts/s3.ts:

import {Endpoint} from '../lib/endpoint';
/* existing code */
var endpoint: Endpoint = s3.endpoint;

The documentation for AWS.S3 states that it exposes a property,
endpoint, which is an AWS.Endpoint object.

However, the declaration for AWS.S3 does not expose the property. This
patch resolves that issue.
@RLovelett
Copy link
Contributor Author

@chrisradek thank you for the review! I have made the changes you've requested.

@coveralls
Copy link

coveralls commented Feb 8, 2017

Coverage Status

Coverage remained the same at 91.83% when pulling 5d9be30 on RLovelett:bugfix/s3-without-endpoint into d0fb1a0 on aws:master.

@coveralls
Copy link

coveralls commented Feb 8, 2017

Coverage Status

Coverage remained the same at 91.83% when pulling 5d9be30 on RLovelett:bugfix/s3-without-endpoint into d0fb1a0 on aws:master.

@chrisradek
Copy link
Contributor

@RLovelett
Thanks! PR looks good to me, merging.

@chrisradek chrisradek merged commit 2928856 into aws:master Feb 8, 2017
@lock
Copy link

lock bot commented Sep 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants