Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with regional endpoints and add integ tests #2994

Merged
merged 2 commits into from
Dec 4, 2019

Conversation

AllanZhengYP
Copy link
Contributor

Checklist
  • npm run test passes
  • .d.ts file is updated
  • changelog is added, npm run add-change
  • run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
  • run npm run integration if integration test is changed

@codecov-io
Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #2994 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2994      +/-   ##
==========================================
- Coverage   97.04%   97.04%   -0.01%     
==========================================
  Files         326      326              
  Lines        9477     9473       -4     
  Branches     1743     1743              
==========================================
- Hits         9197     9193       -4     
  Misses        280      280
Impacted Files Coverage Δ
lib/services/s3.js 98.19% <100%> (-0.01%) ⬇️
lib/services/sts.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66a5e5b...3d2a3f7. Read the comment docs.

@AllanZhengYP AllanZhengYP merged commit 534033a into aws:master Dec 4, 2019
@lock
Copy link

lock bot commented Dec 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants