Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert metadata service modules to functions #3954

Merged
merged 3 commits into from
Nov 11, 2021
Merged

Convert metadata service modules to functions #3954

merged 3 commits into from
Nov 11, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 10, 2021 •
edited
Loading

Fixes: #3952
Follow-up to #3853

Testing

Docs can be viewed at https://aws-sdk-js-3952.netlify.app/
The metadata service modules are not shown under Top Level Namespace.

Checklist
  • npm run test passes
  • changelog is added, npm run add-change

@trivikr trivikr marked this pull request as ready for review November 10, 2021 23:52
@trivikr trivikr requested a review from a team as a code owner November 10, 2021 23:52
@trivikr trivikr merged commit f2b5aaa into aws:master Nov 11, 2021
@trivikr trivikr deleted the metadata_service_fix branch November 11, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The internal code from Metadata service is shown under Top Level namespace in docs
2 participants
@trivikr @AllanZhengYP