Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the 'UnexpectedParameter' when updating the task definition to use Service Connect #4310

Closed
wants to merge 4 commits into from

Conversation

veglos
Copy link

@veglos veglos commented Dec 31, 2022

Fix the 'UnexpectedParameter' when updating the task definition to use Service Connect:
aws-actions/amazon-ecs-deploy-task-definition#426
aws-actions/amazon-ecs-deploy-task-definition#430

https://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/ECS.html#registerTaskDefinition-property

Checklist
  • .d.ts file is updated
  • changelog is added, npm run add-change

@veglos veglos requested a review from a team as a code owner December 31, 2022 21:02
@veglos veglos closed this Dec 31, 2022
@dbcall2
Copy link

dbcall2 commented Sep 11, 2023

Can we get this merged please? Service connect is unusable through the ecs task registration client.

Copy link

@leitel98 leitel98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aBurmeseDev
Copy link
Member

Hi @veglos - thanks for reaching out and apology for the delay.

This's auto-generated by service API (ECS), in fact there's already a PR that would address/fix this: aws-actions/amazon-ecs-deploy-task-definition#529

Since there's no action needed from SDK end, I'll go ahead and close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants