Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bugs in dynamodb integration test #1065

Merged
merged 1 commit into from
Oct 12, 2018
Merged

fix bugs in dynamodb integration test #1065

merged 1 commit into from
Oct 12, 2018

Conversation

sunchunqiang
Copy link

@sunchunqiang sunchunqiang commented Sep 9, 2018 •
edited by mutablealligator
Loading

Description

Fixed bugs in DynamoDB integration test

Motivation and Context

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

sstevenkang
sstevenkang reviewed Sep 11, 2018
View reviewed changes
Copy link
Contributor

@sstevenkang sstevenkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankmuellr frankmuellr requested a review from minbi October 2, 2018 21:19
@sstevenkang
Copy link
Contributor

This fails our integ tests. I am meeting with @sunchunqiang tomorrow so we'll discuss then how to proceed.

@aws-sdk-dotnet-automation aws-sdk-dotnet-automation merged commit 8c6bd5c into aws:master Oct 12, 2018
@diehlaws diehlaws added pr/ready-to-merge This PR is ready to be merged." and removed ready-to-be-merged labels Jan 3, 2019
aws-sdk-dotnet-automation pushed a commit that referenced this pull request Jun 20, 2024
@philasmar
Merge pull request #1065 from aws/asmarp/fix-ddb-dictionary-error
8ffbcaf 
fix: fix ddb error when derived and base class have same member name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstevenkang sstevenkang sstevenkang left review comments

@mutablealligator mutablealligator mutablealligator approved these changes

@minbi minbi minbi approved these changes

Assignees

@sunchunqiang sunchunqiang

Labels
pr/ready-to-merge This PR is ready to be merged." Xamarin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sunchunqiang @sstevenkang @minbi @mutablealligator @frankmuellr @diehlaws @aws-sdk-dotnet-automation