-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is cache_control header blacklisted for generation of signed URLs? #1051
Comments
So, if I understand you correctly, you're relying on the signature to show that the In any case, I'll re-check that it needs to be on the blacklist, although our direction is moving towards a whitelist of headers in the future, potentially. I think there's a feature request here to whitelist headers for signing. I think it's fair for you to say: "Sign this header, I understand that I'm now responsible for ensuring it is not modified in transit to the server, and that there will be an error if it is." |
Yes, you understood me correctly. And yeah, that whitelist would be totally okay for me. |
Adding to feature request backlog. Will also take a PR for this if you want to take a crack at it. |
Hi there! Due to this issue we are still stuck at SDK version 2.2.5. We now want to use the upload acceleration which is not supported by 2.2.5 AFAICS. |
I've added review notes to that PR, and we'll work on getting that in. |
Hi again, we worked around our upload acceleration issue with 2.2.5 by simply patching the URL. |
Hi there,
for #1026 a list of headers were excluded from signature for various reasons.
One of them (
cache_control
) is used by me in presigned URLs and I want to rely upon it to ensure that uploaded objects have the proper cache control settings.For me this is a blocker for upgrading beyond 2.2.5. Of course I could monkey patch the signer but that is not really what I want to do.
If it is really necessary to have this header excluded from signature it may be a solution to make its exclusion optional.
The text was updated successfully, but these errors were encountered: