Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is cache_control header blacklisted for generation of signed URLs? #1051

Closed
toaster opened this issue Jan 9, 2016 · 6 comments
Closed
Assignees
Labels
feature-request A feature should be added or improved.

Comments

@toaster
Copy link

toaster commented Jan 9, 2016

Hi there,

for #1026 a list of headers were excluded from signature for various reasons.
One of them (cache_control) is used by me in presigned URLs and I want to rely upon it to ensure that uploaded objects have the proper cache control settings.
For me this is a blocker for upgrading beyond 2.2.5. Of course I could monkey patch the signer but that is not really what I want to do.
If it is really necessary to have this header excluded from signature it may be a solution to make its exclusion optional.

@awood45
Copy link
Member

awood45 commented Jan 9, 2016

So, if I understand you correctly, you're relying on the signature to show that the cache-control header is not modified by your customer?

In any case, I'll re-check that it needs to be on the blacklist, although our direction is moving towards a whitelist of headers in the future, potentially.

I think there's a feature request here to whitelist headers for signing. I think it's fair for you to say: "Sign this header, I understand that I'm now responsible for ensuring it is not modified in transit to the server, and that there will be an error if it is."

@awood45 awood45 added feature-request A feature should be added or improved. Version 2 labels Jan 9, 2016
@awood45 awood45 self-assigned this Jan 9, 2016
@toaster
Copy link
Author

toaster commented Jan 10, 2016

Yes, you understood me correctly. And yeah, that whitelist would be totally okay for me.

awood45 added a commit that referenced this issue Feb 3, 2016
Adds feature requests related to issues #1047 and #1051.
@awood45
Copy link
Member

awood45 commented Feb 3, 2016

Adding to feature request backlog. Will also take a PR for this if you want to take a crack at it.

@toaster
Copy link
Author

toaster commented Jul 8, 2016

Hi there!

Due to this issue we are still stuck at SDK version 2.2.5. We now want to use the upload acceleration which is not supported by 2.2.5 AFAICS.
Is there any chance that #1228 will be merged any time soon?

@awood45
Copy link
Member

awood45 commented Jul 8, 2016

I've added review notes to that PR, and we'll work on getting that in.

@toaster
Copy link
Author

toaster commented Nov 30, 2016

Hi again,

we worked around our upload acceleration issue with 2.2.5 by simply patching the URL.
But now we want to use signed CloudFront URLs. But, alas, the Aws::CloudFront::UrlSigner does not exist in 2.2.5.
This problem has now evolved from “annoying” to “blocker” for us.
When will the PR get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants