Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow AWS.config setting for retries in the EC2 credential provider #717

Closed
rb2k opened this issue Feb 25, 2015 · 5 comments
Closed

Allow AWS.config setting for retries in the EC2 credential provider #717

rb2k opened this issue Feb 25, 2015 · 5 comments
Labels
feature-request A feature should be added or improved.

Comments

@rb2k
Copy link

rb2k commented Feb 25, 2015

As mentioned over here: #634 (comment)
It would be nice to have a way to set this as part of the global configuration.

@wjordan
Copy link

wjordan commented Nov 2, 2018

For reference, the AWS CLI (via botocore) allows configuration of EC2 credential retries/timeouts through metadata_service_num_attempts / metadata_service_timeout variables in the global configuration as well as AWS_METADATA_SERVICE_TIMEOUT / AWS_METADATA_SERVICE_NUM_ATTEMPTS environment variables (see source).

If this feature is ever implemented in the Ruby SDK it would be nice to re-use these existing names for reuse/consistency across the two SDKs.

@wjordan
Copy link

wjordan commented Oct 7, 2020

@mullermp could you please reopen this issue, now that the Feature Requests backlog markdown file has been deprecated/removed?

@mullermp mullermp reopened this Oct 8, 2020
@mullermp
Copy link
Contributor

mullermp commented Oct 8, 2020

I'd have to check in with other SDKs on whether to support this or not. Generally, customers request features to other SDKs because "CLI does it" but sometimes it's not necessary because of the nature of CLI versus a language SDK.

@mullermp
Copy link
Contributor

mullermp commented Dec 3, 2020

It looks like this original feature request was already implemented (for allowing retries through code) so I'm going to close this. https://github.com/aws/aws-sdk-ruby/blob/master/gems/aws-sdk-core/lib/aws-sdk-core/instance_profile_credentials.rb#L62

For supporting global configuration and environment variables, we should open a new feature request and then I would need to check with other SDK teams on whether they can support it. Generally CLI has different configuration mechanisms because .. it's the CLI (and files/ENV makes sense) over code configuration (language runtime).

@mullermp mullermp closed this as completed Dec 3, 2020
@github-actions
Copy link

github-actions bot commented Dec 3, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

4 participants