-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry(amazonq): add field to track auth type to metric #718
Conversation
@@ -2841,6 +2841,10 @@ | |||
{ | |||
"type": "codeTransformSessionId", | |||
"required": true | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the definition for that type:
{
"name": "enabledAuthConnections",
"type": "string",
"description": "Comma delimited list of enabled auth connections"
},
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to put it in projectDetails
metric? The jobIsStartedFromChatPrompt
and the isDoubleClickedToTrigger...
metric names are slowly getting replaced by projectDetails
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in Slack: going to use jobIsStartedFromChatPrompt
for now since projectDetails
is always emitted on IDE startup; we want this metric to capture just users who tried transforming a valid project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentative approval: moving discussion into slack
aws-toolkit-common/telemetry/definitions/commonDefinitions.json Lines 763 to 776 in b7f0554
|
Problem
Want a field to track if user is authenticated with BuilderId or IdC for QCT.
Solution
Use an existing auth-related field and add it to an existing metric which will be emitted when /transform is invoked.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.