Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry(amazonq): add field to track auth type to metric #718

Merged
merged 2 commits into from
Apr 5, 2024
Merged

telemetry(amazonq): add field to track auth type to metric #718

merged 2 commits into from
Apr 5, 2024

Conversation

dhasani23
Copy link
Contributor

Problem

Want a field to track if user is authenticated with BuilderId or IdC for QCT.

Solution

Use an existing auth-related field and add it to an existing metric which will be emitted when /transform is invoked.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dhasani23 dhasani23 requested a review from a team as a code owner April 4, 2024 06:56
@@ -2841,6 +2841,10 @@
{
"type": "codeTransformSessionId",
"required": true
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the definition for that type:

        {
            "name": "enabledAuthConnections",
            "type": "string",
            "description": "Comma delimited list of enabled auth connections"
        },
        ```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to put it in projectDetails metric? The jobIsStartedFromChatPrompt and the isDoubleClickedToTrigger... metric names are slowly getting replaced by projectDetails.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in Slack: going to use jobIsStartedFromChatPrompt for now since projectDetails is always emitted on IDE startup; we want this metric to capture just users who tried transforming a valid project.

Copy link
Contributor

@damntrecky damntrecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative approval: moving discussion into slack

@justinmk3
Copy link
Contributor

Want a field to track if user is authenticated with BuilderId or IdC for QCT.

credentialSourceId can be used for that (awsId = "builder id"):

"name": "credentialSourceId",
"type": "string",
"description": "Where credentials are stored or retrieved from",
"allowedValues": [
"sharedCredentials",
"sdkStore",
"ec2",
"ecs",
"envVars",
"awsId",
"iamIdentityCenter",
"memory",
"other"
]

@justinmk3 justinmk3 merged commit 59faad1 into aws:main Apr 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants