Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemtry:(amazonq): Add more metadata fields to capture duration, result, failure reason to amazonq events #729

Conversation

sarayev
Copy link
Contributor

@sarayev sarayev commented May 3, 2024

Problem

We want to track duration, result, failure reason, requestId and requestServiceType fields for startConversationInvoke, approachInvoke, createUpload and codeGenerationInvoke events in JetBrains.

Solution

In toolkits, we get those fields added to the telemetry events when we do telemetry.event.run{}, however in JetBrains it isn't supported. Therefore, adding them as metadata fields.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sarayev sarayev requested a review from a team as a code owner May 3, 2024 14:01
Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for using existing fields instead of creating special-purpose fields that are semantically the same as existing fields.

@justinmk3 justinmk3 merged commit 7a55780 into aws:main May 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants