Add Action to setup release candidate branch #4204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodnyab
changed the title
|
rli
reviewed
Mar 25, 2024
| - name: Set up release branch | ||
| env: | ||
| releaseBranch: "release/candidate/${{inputs.versionNumber}}" | ||
| if: ${{ env.EXISTS == 'false' }} |
There was a problem hiding this comment.
do we still need this if the previous step will exit with failure
| inputs: | ||
| commitId: | ||
| description: "Commit Id" | ||
| default: "" |
There was a problem hiding this comment.
can we default this to the current HEAD of main
rli
approved these changes
Mar 25, 2024
rli
reviewed
Mar 26, 2024
| - name: Set up release branch | ||
| env: | ||
| releaseBranch: "release/candidate/${{inputs.versionNumber}}" | ||
| if: ${{ env.EXISTS == 'false' }} |
There was a problem hiding this comment.
https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions
if: ${{ success() }}
also works, to avoid polluting the env vars
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
GH Action to manually setup a release branch
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.