-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amazon Q Code Transform: Improve telemetry to capture transform journey #4731
Conversation
...ity/src/software/aws/toolkits/jetbrains/services/codemodernizer/ideMaven/MavenRunnerUtils.kt
Show resolved
Hide resolved
CodeTransformPreValidationError.NonMavenProject, | ||
if (isGradleProject(project)) "Gradle build" else "other build" | ||
) | ||
), | ||
buildSystem = if (isGradleProject(project)) CodeTransformBuildSystem.Gradle else CodeTransformBuildSystem.Unknown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now this isGradleProject()
is just used for telemetry right? Looks like it's implemented here:
Line 10 in 3c8beb6
fun isGradleProject(project: Project) = !GradleSettings.getInstance(project).linkedProjectsSettings.isEmpty() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - It's just for telemetry and it's using the function from the util.
Instead of removing the deprecated metrics, I should keep them for short term backward compatibility for BI analysis purpose. I will add them back, and remove them after BI team confirms no longer needing the old metrics. |
Types of changes
Description
Emit new metrics to better capture user journey for Amazon Q Code Transform.
Remove deprecated metrics.
New metrics published:
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.