Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transform v1 sampling rules to v2 format #70

Merged
merged 1 commit into from
Nov 14, 2018
Merged

fix: transform v1 sampling rules to v2 format #70

merged 1 commit into from
Nov 14, 2018

Conversation

chrisradek
Copy link
Contributor

Issue #, if available:
Fixes #65
Description of changes:
Updates the LocalSampler so that it copies all valid config rules to its internal rules.
The service_name field still gets renamed to host if version is 1.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@haotianw465 haotianw465 merged commit 740ec82 into aws:master Nov 14, 2018
@chrisradek chrisradek deleted the fix-local-sampling-v1 branch November 14, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants