Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secrets Manager not supported? #811

Closed
jpi-car opened this issue Apr 25, 2018 · 5 comments
Closed

Secrets Manager not supported? #811

jpi-car opened this issue Apr 25, 2018 · 5 comments

Comments

@jpi-car
Copy link

jpi-car commented Apr 25, 2018

Directly mirroring from aws/aws-sam-cli#367, I'm having issues with deploying my Chalice app when I try to use Secrets Manager. When deployed, the app errors out with this error: module initialization error: Unknown service: 'secretsmanager'. I tried following the suggestion in the provided link above by using pip wheel boto3, and then placing the generated pip wheels inside the vendor folder, however this didn't solve the issue.

@owenbrown
Copy link

Please add support for secrets.

@atimzhao
Copy link

+1

@stealthycoin
Copy link
Contributor

stealthycoin commented Apr 25, 2018

Not sure exactly what you mean by add support for this in Chalice. The runtime dependencies are entirely up to you. You can supply any version of botocore/boto3 by specifying it in requirements.txt.

Looks like secrets manager was added in this commit: boto/botocore@8619929 which corresponds to botocore 1.9.23.

So you just need botocore>=1.9.23 in your requirements.txt.

@jpi-car
Copy link
Author

jpi-car commented Apr 25, 2018

@stealthycoin Ah, haha. Thank you very much. That was a silly mistake of me. Closing.

@jpi-car jpi-car closed this as completed Apr 25, 2018
@ilyaGotfryd
Copy link

While this issue is closed pulling values from Secrets Manager at the time of the deployment to reside as environment variables with an instance of Lambda is a common place pattern. It would be a proper feature to implement. I run into this need literally with every new project I push into production.
Please reconsider this as a basic security requirement and not a frivolous want as indicated by response in this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants