Support for both api_key_required AND authorizer on routes #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed to support routes that need both an api_key and an authorizer.
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
+ Coverage 94.01% 94.04% +0.03%
==========================================
Files 18 18
Lines 2940 2941 +1
Branches 380 381 +1
==========================================
+ Hits 2764 2766 +2
Misses 129 129
+ Partials 47 46 -1
Continue to review full report at Codecov.
|
|
Thanks for the pull request. Per our Contributing guidelines we just need to get a test added for this before this can get merged. Would you be able to add a test in tests/unit/deploy/test_swagger.py for this fix? |
jamesls
added a commit
to jamesls/chalice
that referenced
this pull request
Sep 5, 2017
This pulls in aws#473 and adds a test for it.
|
Rebased against master and added a test for this here: #473 Thanks again for the pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to support routes that need both an api_key and an authorizer.