Chalice local 200s CORS OPTIONS rather than 403 #554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #554 +/- ##
==========================================
- Coverage 94.43% 94.43% -0.01%
==========================================
Files 18 18
Lines 3129 3127 -2
Branches 402 402
==========================================
- Hits 2955 2953 -2
Misses 126 126
Partials 48 48
Continue to review full report at Codecov.
|
|
@corespace Thanks for the submission! Could you also throw out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks,
My local preflights got broken, so this should fix them. Ran coverage reports before/after and no changes there. You could probably delete
class NoOptionsRouteDefined, but I didn't want to make that call myself.Thanks!
-Kyle