allow using a pre-configured IAM role #62
Conversation
|
Sorry for the delay, I've been OOTO until today. Overall, I think this change looks good. I do have one question. In considering additional features such as #40 where I'd like to track everything I create so that I can subsequently delete them in a Not really sure what to call the config option, but some sort of boolean config option that explicitly says "don't touch the role_arn". What do you think? |
Be consistent wtih botocore/boto3 sphinx docs.
|
good idea! done. also, changed the config keys to iam_role_arn and manage_iam_role so that it is clear we are talking about iam roles. thanks! |
* user-docs-start: Add topic guide for routing Add API docs Add quickstart to guide Initial commit of user docs Use guzzle_sphinx_theme
|
Hello, Let me know if you want me to make any changes. I am fairly new to python, so, don't hesitate to comment on my code - i will learn something. thanks. |
|
this build seems to have failed due to some documentation changes unrelated to this pull request. |
|
Thanks. Would you mind squashing your commits and rebasing against master? That should fix the doc errors you're seeing. |
if an IAM role is configured, use that instead of creating new how to use a pre-configured IAM role instead of creating new added boolean config param manage_iam_role to explicitly turn iam on or off added boolean config param manage_iam_role to explicitly turn iam on or off update doc to show new keys for managing iam role broke a too long line into two lines removed formatting changes my commit added to other people's code if an IAM role is configured, use that instead of creating new added boolean config param manage_iam_role to explicitly turn iam on or off if an IAM role is configured, use that instead of creating new update doc to show new keys for managing iam role broke a too long line into two lines removed formatting changes my commit added to other people's code fixed typo!
|
squashing and rebase was getting complicated. I just re-did a new fork, manually applied changes and requested a new pull #85. Closing this. |
see issue #61. This is my proposal to fix it.