chore(addons): merge two cfn template's Metadata section #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamhopaul123
approved these changes
Jun 4, 2020
| metadataSection cfnSection = iota + 1 | ||
| ) | ||
|
|
||
| // cloudformation represents a parsed YAML AWS CloudFormation template. |
There was a problem hiding this comment.
What do you think of renaming to "cfnTemplate" which will be more informative and avoiding struct and pkg sharing the same name cloudformation?
| type cfnSection int | ||
|
|
||
| const ( | ||
| metadataSection cfnSection = iota + 1 |
kohidave
reviewed
Jun 4, 2020
go.mod
Outdated
| golang.org/x/text v0.3.2 // indirect | ||
| gopkg.in/ini.v1 v1.57.0 | ||
| gopkg.in/yaml.v2 v2.3.0 |
There was a problem hiding this comment.
I have no idea 🤷♂️ I ran go mod tidy again and cleaned up a bunch of old dependencies.
I wonder if I can get dependabot to run tidy periodically 💭
efekarakus
added
the
do-not-merge
|
I updated the PR with an additional function
|
efekarakus
removed
the
do-not-merge
kohidave
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges the "Metadata" section of two cfn templates under "addons/".
Related to #994
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.