Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit of README content #1

Merged
merged 19 commits into from
Aug 30, 2019
Merged

Initial commit of README content #1

merged 19 commits into from
Aug 30, 2019

Conversation

ragona
Copy link
Contributor

@ragona ragona commented Aug 23, 2019

Added a description of Crypto Tools and our software, plus relevant links.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@ragona
Copy link
Contributor Author

ragona commented Aug 25, 2019

Yessss @mattsb42-aws that is such a helpful review! Looking forward to getting this thing cleaned up. I'll put out a rev tomorrow. 👍

ragona and others added 6 commits August 25, 2019 17:09
Co-Authored-By: Matt Bullock <bullocm@amazon.com>
Co-Authored-By: Matt Bullock <bullocm@amazon.com>
Co-Authored-By: Matt Bullock <bullocm@amazon.com>
@jellywish jellywish self-requested a review August 26, 2019 02:04
README.md Outdated
We welcome issues and PRs on any of our repositories.

# Jobs
Interested in helping us making the world more secure? [We're hiring](https://www.amazon.jobs/en/search?cities[]=Seattle%2C%20Washington%2C%20USA&business_category[]=amazon-web-services&base_query=crypto%20tools)!
Copy link

@jellywish jellywish Aug 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done this kind of GitHub review before, so I'm experimenting here. I'd like to eliminate the "helping us" phrase, because we're looking for people who want to make the world more secure, not help us, although by making the world more secure they'll be helping us. :-)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ragona and others added 2 commits August 26, 2019 10:46
Co-Authored-By: Spencer Janyk <6957473+jellywish@users.noreply.github.com>
Co-Authored-By: Spencer Janyk <6957473+jellywish@users.noreply.github.com>
Copy link
Member

@mattsb42-aws mattsb42-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not seeing any links to docs.aws.amazon.com. Is that intentional?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ragona and others added 5 commits August 27, 2019 20:42
Co-Authored-By: Matt Bullock <bullocm@amazon.com>
Co-Authored-By: Matt Bullock <bullocm@amazon.com>
Co-Authored-By: Matt Bullock <bullocm@amazon.com>
Co-Authored-By: Matt Bullock <bullocm@amazon.com>
Co-Authored-By: Matt Bullock <bullocm@amazon.com>
Copy link
Member

@mattsb42-aws mattsb42-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we should link to the appropriate places on docs.aws.amazon.com, but we can add that later.

@mattsb42-aws mattsb42-aws merged commit c7779e3 into aws:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants