Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Porting Assistant .NET 8 Support #1193

Merged
merged 8 commits into from
Oct 26, 2023
Merged

feat: Porting Assistant .NET 8 Support #1193

merged 8 commits into from
Oct 26, 2023

Conversation

mrkdeng
Copy link
Contributor

@mrkdeng mrkdeng commented Oct 23, 2023

Related issue

Not applicable, this is a new feature.

Description

This CR includes changes needed to support .NET 8.

Supplemental testing

  1. Update existing tests by adding .NET 8 to supported framworks.
  2. Add .NET 8 as test case to tests written for .NET 7 and above.

Additional context

All tests passed with proper rule files, see #1194. This PR will be fully ready once this CR aws/porting-assistant-dotnet-datastore#161 gets merged.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mrkdeng mrkdeng self-assigned this Oct 23, 2023
@mrkdeng mrkdeng marked this pull request as ready for review October 25, 2023 03:28
@mrkdeng mrkdeng requested a review from jonlouie October 25, 2023 17:56
@mrkdeng mrkdeng merged commit 9ed65af into main Oct 26, 2023
1 check passed
@mrkdeng mrkdeng deleted the feat_dotnet8_support branch October 26, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants