Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handling of empty packages sequence #1195

Merged
merged 7 commits into from
Feb 26, 2024
Merged

fix: handling of empty packages sequence #1195

merged 7 commits into from
Feb 26, 2024

Commits on Feb 21, 2024

  1. fix: handling of empty packages sequence 

    The call to .ToDictionary was throwing exemption if the sequence contains no elements.
    @cslong
    cslong committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    8b6cf7e View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. test: test project file creation logic 

    * verify add new packages, and maintain existing
* verify no exception for no packages
* verify no exception for packages removed because existing
    @cslong
    cslong committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    f20393b View commit details
    Browse the repository at this point in the history

  2. test: handling of no existing packages in project

    @cslong
    cslong committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    764c5b3 View commit details
    Browse the repository at this point in the history

  3. Revert "fix: handling of empty packages sequence" 

    This reverts commit 8b6cf7e.
    @cslong
    cslong committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    3eaab8c View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. fix: unhandled exception when package reference without version 

    First() will throw exception if the Version or Include attributes are not found
    @cslong
    cslong committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b894d39 View commit details
    Browse the repository at this point in the history

  2. test: update expected tests results 

    In response to change in the datastore, aws/porting-assistant-dotnet-datastore@ba2603d. .NET 7 should be getting a specific version of the Microsoft.EntityFrameworkCore
    @cslong
    cslong committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    8c0eb67 View commit details
    Browse the repository at this point in the history

  3. test: update expected tests results 

    In response to change in the datastore, aws/porting-assistant-dotnet-datastore@ba2603d. .NET 7 should be getting a specific version of the Microsoft.EntityFrameworkCore
    @cslong
    cslong committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    dacf2bf View commit details
    Browse the repository at this point in the history