Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Skip ECR Scan on TF 2.4.1 images #880

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

saimidu
Copy link
Contributor

@saimidu saimidu commented Feb 24, 2021

Issue #, if available:

PR Checklist

  • I've prepended PR tag with frameworks/job this applies to : [mxnet, tensorflow, pytorch] | [ei/neuron] | [build] | [test] | [benchmark] | [ec2, ecs, eks, sagemaker]
  • (If applicable) I've documented below the DLC image/dockerfile this relates to
  • (If applicable) I've documented below the tests I've run on the DLC image
  • (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the Apache Software Foundation Third Party License Policy Category A or Category B license list. See https://www.apache.org/legal/resolved.html.
  • (If applicable) I've scanned the updated and new binaries to make sure they do not have vulnerabilities associated with them.

Reviewer Checklist

  • For reviewer, before merging, please cross-check:
  • I've verified the code change on the config file mentioned above has already been reverted

Description:
Skip the ECR Scan check on TF 2.4.1 docker images

Tests run:

DLC image/dockerfile:

Additional context:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@saimidu saimidu self-assigned this Feb 24, 2021
@@ -47,6 +50,11 @@ def test_ecr_scan(image, ecr_client):
:param image: str Image URI for image to be tested
:param ecr_client: boto3 Client for ECR
"""
# TODO: Unskip this test for TF 2.4.1 images
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also create a git issue for this

@saimidu saimidu merged commit 384ba93 into aws:master Feb 24, 2021
@saimidu saimidu deleted the skip_ecr_scan_tf_2.4.1 branch February 24, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants