Adds wait for not ready for external etcd before upgrade #2640
Conversation
eks-distro-bot
added
the
size/L
Codecov Report
@@ Coverage Diff @@
## main #2640 +/- ##
==========================================
+ Coverage 57.39% 57.46% +0.07%
==========================================
Files 310 310
Lines 25506 25538 +32
==========================================
+ Hits 14638 14675 +37
+ Misses 9532 9527 -5
Partials 1336 1336
Continue to review full report at Codecov.
|
jiayiwang7
force-pushed
the
jgw/wait-not-ready-etcd
branch
from
b89e3e6
to
03568e2
Compare
vivek-koppuru
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-0.10 |
|
@mitalipaygude: new pull request created: #2676 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-0.10 |
|
@mitalipaygude: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/eks-distro-pr-bot/eks-anywhere\n ! [rejected] cherry-pick-2640-to-release-0.10 -> cherry-pick-2640-to-release-0.10 (non-fast-forward)\nerror: failed to push some refs to 'https://eks-distro-pr-bot:CENSORED@github.com/eks-distro-pr-bot/eks-anywhere'\nhint: Updates were rejected because the tip of your current branch is behind\nhint: its remote counterpart. Integrate the remote changes (e.g.\nhint: 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-0.10 |
|
@mitalipaygude: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/eks-distro-pr-bot/eks-anywhere\n ! [rejected] cherry-pick-2640-to-release-0.10 -> cherry-pick-2640-to-release-0.10 (non-fast-forward)\nerror: failed to push some refs to 'https://eks-distro-pr-bot:CENSORED@github.com/eks-distro-pr-bot/eks-anywhere'\nhint: Updates were rejected because the tip of your current branch is behind\nhint: its remote counterpart. Integrate the remote changes (e.g.\nhint: 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-0.10 |
|
@pokearu: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/eks-distro-pr-bot/eks-anywhere\n ! [rejected] cherry-pick-2640-to-release-0.10 -> cherry-pick-2640-to-release-0.10 (non-fast-forward)\nerror: failed to push some refs to 'https://eks-distro-pr-bot:CENSORED@github.com/eks-distro-pr-bot/eks-anywhere'\nhint: Updates were rejected because the tip of your current branch is behind\nhint: its remote counterpart. Integrate the remote changes (e.g.\nhint: 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
When upgrading a cluster sometimes, it appears to be when the machine is stressed and the bootstrap cluster is running slow, control plane nodes are not upgraded and etcd nodes are left behind. This adds a similar fix to #1542 for external etcd nodes to ensure the cli is waiting for it to upgrade before moving on.
Should fix #2636
Note: @jiayiwang7 is going to finish this by adding tests.
Description of changes:
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.