Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snow conformance test in e2e #3433

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

jiayiwang7
Copy link
Member

Issue #, if available:

#1108

Description of changes:

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 23, 2022
@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Merging #3433 (00871c9) into main (b86056e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3433   +/-   ##
=======================================
  Coverage   64.91%   64.91%           
=======================================
  Files         351      351           
  Lines       28422    28422           
=======================================
  Hits        18449    18449           
  Misses       8660     8660           
  Partials     1313     1313           
Impacted Files Coverage Δ
pkg/workflows/create.go 61.09% <0.00%> (ø)
pkg/workflows/delete.go 59.73% <0.00%> (ø)
pkg/workflows/upgrade.go 64.59% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@panktishah26
Copy link
Member

/lgtm

@panktishah26
Copy link
Member

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: panktishah26

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 9bafa09 into aws:main Sep 23, 2022
@jiayiwang7 jiayiwang7 deleted the snow-conformance branch September 28, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants