-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snow static ip e2e tests #4979
Conversation
23eb2ad
to
11c2356
Compare
Codecov Report
@@ Coverage Diff @@
## main #4979 +/- ##
==========================================
- Coverage 71.92% 71.92% -0.01%
==========================================
Files 420 420
Lines 34213 34213
==========================================
- Hits 24609 24606 -3
- Misses 8084 8086 +2
- Partials 1520 1521 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
0f761cc
to
04a6c9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small questions.
Adding lgtm in case we are comfortable with current test coverage. Happy to give another lgtm if we decide to add more unit tests.
/lgtm
@@ -22,6 +22,10 @@ const ( | |||
snowPodCidr = "T_SNOW_POD_CIDR" | |||
snowCredentialsFile = "EKSA_AWS_CREDENTIALS_FILE" | |||
snowCertificatesFile = "EKSA_AWS_CA_BUNDLES_FILE" | |||
snowIPPoolIPStart = "T_SNOW_IPPOOL_IPSTART" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's worth documenting what these values should be when configuring your snow e2e setup? I realize we don't actually have a lab to run against right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
04a6c9c
to
6e4d710
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jonathanmeier5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Description of changes:
#1108
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.