Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snow static ip e2e tests #4979

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

jiayiwang7
Copy link
Member

Issue #, if available:

Description of changes:

#1108

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 15, 2023
@jiayiwang7 jiayiwang7 force-pushed the snow-e2e-static-ip branch 3 times, most recently from 23eb2ad to 11c2356 Compare February 15, 2023 20:33
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #4979 (6e4d710) into main (b7430c7) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4979      +/-   ##
==========================================
- Coverage   71.92%   71.92%   -0.01%     
==========================================
  Files         420      420              
  Lines       34213    34213              
==========================================
- Hits        24609    24606       -3     
- Misses       8084     8086       +2     
- Partials     1520     1521       +1     
Impacted Files Coverage Δ
pkg/providers/vsphere/vsphere.go 62.58% <0.00%> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jiayiwang7 jiayiwang7 force-pushed the snow-e2e-static-ip branch 2 times, most recently from 0f761cc to 04a6c9c Compare February 16, 2023 13:52
Copy link
Member

@jonathanmeier5 jonathanmeier5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small questions.

Adding lgtm in case we are comfortable with current test coverage. Happy to give another lgtm if we decide to add more unit tests.

/lgtm

@@ -22,6 +22,10 @@ const (
snowPodCidr = "T_SNOW_POD_CIDR"
snowCredentialsFile = "EKSA_AWS_CREDENTIALS_FILE"
snowCertificatesFile = "EKSA_AWS_CA_BUNDLES_FILE"
snowIPPoolIPStart = "T_SNOW_IPPOOL_IPSTART"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth documenting what these values should be when configuring your snow e2e setup? I realize we don't actually have a lab to run against right now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

internal/pkg/api/snow.go Show resolved Hide resolved
internal/pkg/api/snowmachines.go Show resolved Hide resolved
Copy link
Member

@jonathanmeier5 jonathanmeier5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jonathanmeier5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 708bb50 into aws:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants