-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Un-Skipping reconciler unit tests for the all providers #7758
Un-Skipping reconciler unit tests for the all providers #7758
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
66b20d0
to
9764ca7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7758 +/- ##
==========================================
+ Coverage 73.48% 73.77% +0.28%
==========================================
Files 579 588 +9
Lines 36357 37162 +805
==========================================
+ Hits 26718 27415 +697
- Misses 7875 7952 +77
- Partials 1764 1795 +31 ☔ View full report in Codecov by Sentry. |
9764ca7
to
07b8719
Compare
/test eks-anywhere-presubmit |
5 similar comments
/test eks-anywhere-presubmit |
/test eks-anywhere-presubmit |
/test eks-anywhere-presubmit |
/test eks-anywhere-presubmit |
/test eks-anywhere-presubmit |
Need some more debugging in un-skipping these tests. Closing this PR. |
Issue #, if available:
https://github.com/aws/eks-anywhere-internal/issues/2193
Description of changes:
We have skipped a few unit tests which were failing randomly on a PR as a part of eks-anywhere-presubmit job. Un-skipping a those unit tests of all the providers.
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.