Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-Skipping reconciler unit tests for the all providers #7758

Conversation

panktishah26
Copy link
Member

@panktishah26 panktishah26 commented Mar 1, 2024

Issue #, if available:
https://github.com/aws/eks-anywhere-internal/issues/2193

Description of changes:
We have skipped a few unit tests which were failing randomly on a PR as a part of eks-anywhere-presubmit job. Un-skipping a those unit tests of all the providers.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from panktishah26. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 1, 2024
@panktishah26 panktishah26 force-pushed the un-skip-reconciler-skipped-unit-test branch 2 times, most recently from 66b20d0 to 9764ca7 Compare March 1, 2024 17:45
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.77%. Comparing base (4583834) to head (07b8719).
Report is 257 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7758      +/-   ##
==========================================
+ Coverage   73.48%   73.77%   +0.28%     
==========================================
  Files         579      588       +9     
  Lines       36357    37162     +805     
==========================================
+ Hits        26718    27415     +697     
- Misses       7875     7952      +77     
- Partials     1764     1795      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panktishah26 panktishah26 force-pushed the un-skip-reconciler-skipped-unit-test branch from 9764ca7 to 07b8719 Compare March 1, 2024 17:55
@panktishah26
Copy link
Member Author

/test eks-anywhere-presubmit

5 similar comments
@panktishah26
Copy link
Member Author

/test eks-anywhere-presubmit

@panktishah26
Copy link
Member Author

/test eks-anywhere-presubmit

@panktishah26
Copy link
Member Author

/test eks-anywhere-presubmit

@panktishah26
Copy link
Member Author

/test eks-anywhere-presubmit

@panktishah26
Copy link
Member Author

/test eks-anywhere-presubmit

@panktishah26
Copy link
Member Author

Need some more debugging in un-skipping these tests. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants