Bump helm to v3.14.2 #7797
Merged
Bump helm to v3.14.2 #7797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/XL
g-gaston
force-pushed
the
bump-helm-v3.14.2
branch
2 times, most recently
from
6d3b9ad
to
36d1d41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7797 +/- ##
=======================================
Coverage 73.55% 73.55%
=======================================
Files 588 588
Lines 37174 37176 +2
=======================================
+ Hits 27344 27346 +2
Misses 8035 8035
Partials 1795 1795 ☔ View full report in Codecov by Sentry. |
g-gaston
force-pushed
the
bump-helm-v3.14.2
branch
from
36d1d41
to
f942d3e
Compare
g-gaston
force-pushed
the
bump-helm-v3.14.2
branch
from
f942d3e
to
16d7bdd
Compare
g-gaston
commented
Mar 6, 2024
| @@ -106,7 +106,7 @@ test: manifests generate fmt vet ## Run tests. | |||
|
|
|||
| ##@ Build | |||
|
|
|||
| build: clean fmt vet ## Build release binary. | |||
| build: clean fmt ## Build release binary. | |||
There was a problem hiding this comment.
I don't think this was ever vetting correctly
Now that I fixed the vet command, it spits a bunch of errors
I'm leaving that to be fixed later in the future. I suspect those errors have been there for a while
g-gaston
force-pushed
the
bump-helm-v3.14.2
branch
2 times, most recently
from
69654ba
to
3421bcd
Compare
eks-distro-bot
added
size/XXL
g-gaston
force-pushed
the
bump-helm-v3.14.2
branch
from
3421bcd
to
f780367
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cxbrowne1207
pushed a commit
to cxbrowne1207/eks-anywhere
that referenced
this pull request
May 8, 2024
cxbrowne1207
pushed a commit
to cxbrowne1207/eks-anywhere
that referenced
this pull request
May 8, 2024
bump helm and controller runtime
cxbrowne1207
added a commit
that referenced
this pull request
May 8, 2024
…8118) * Bump controller-runtime to v0.16.5 (#7788) `controller-runtime` v0.16.5 - Fake client breaking changes: - Start using `WithStatusSubresource` when we care about status being treated differently through `Update` calls. This is basically all controllers. - Add a finalizer when creating an object directly with a deletion timestamp. This make sense since any controller interested in the delete flow should be already adding finalizers. - Signature of `Watches` for creating a controller has been simplified and doesn't need the `source.Kind` wrapper. - Manager options signature has changed. Now metrics and webhook fields are nested in its own second level struct. - Validation webhooks now return a `(admission.Warnings, error)` instead of just `error`. We are not using this functionality for now, but we had to update all our webhooks and test to follow the new signature. - `handler.MapFunc` has changed, now they take a context as well. We don't use the context but need to conform to the new signature. `cluster-api` v1.6.2 - When setting up cluster tracker, the variable `DefaultIndexes` is removed, now we use `[]Index{NodeProviderIDIndex}` CAPC We are still waiting for capc to be updated to capi v1.5, which would enable us to move to controller-runtime v0.15. It's taking quite long and we got to the point where this is preventing us from updating moduled (like helm) that we need to update ASAP. I opted for "vendoring" just the api structs we need from capc. In order to contain changes and allow for an easy "revert" to use the original module (whenever we can), I created a dummy module so I can just use a `replace` in our go.mod and point to our vendored folder. I put this in `internal/thirdparty/capc`. You don't need to review that code, I just copied it. Assertions in gomock I had to change some of the assertions in the cluster manager tests. Now they are less strict since they use type instead of content assertion. TBH, they were wrong from the beginning since they expected current and new spec to be the same, so if so, this makes the test slightly better. I checked and I believe all this is already dead code because of the workflow refactors we did in v0.19.0. It's just that the code hasn't been deleted yet. I'll push to get all this crap removed. CAPV They just change the package where they have the api structs from `api/[version]` to `apis/[version]`. * Bump helm to v3.14.2 (#7797) bump helm and controller runtime * Bump x/net (#7945) bump net/x to fix vulnerability * go mod tidy * Bump Go version to 1.21 (#7805) * Bump helm froo 3.14.2 to 3.14.4 (#8119) * go mod tidy * fix linting errors --------- Co-authored-by: Guillermo Gaston <gaslor@amazon.com> Co-authored-by: Xu Deng <xudeng@amazon.com> Co-authored-by: Abhay Krishna <arnchlm@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This started as just a helm update.
However, a few commands in the release/cli module seem to not be working, they appeared to not be handling correctly the fact that the module is
cliand not inrelease.I fixed those. However, the unit tests for the release cli were then failing. This wasn't because of the helm or any other module update. The tests were actually broken.
I suspect because of the incorrect command, the tests haven't been running for a while, hence we never detected the issue.
The fix was easy, just a matter of changing the expected results. I believe when we changed the versioning logic for dev releases, these test broke. But since they didn't run, we didn't fix them.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.