add persistent storage example #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterkain
changed the title
|
Yes I forgot about it, please add it to the table too. Thanks |
stefanprodan
suggested changes
Oct 23, 2019
stable/appmesh-prometheus/README.md
Outdated
| @@ -56,4 +82,5 @@ Parameter | Description | Default | |||
| `rbac.pspEnabled` | If `true`, create and use a restricted pod security policy | `false` | |||
| `serviceAccount.create` | If `true`, create a new service account | `true` | |||
| `serviceAccount.name` | Service account to be used | None | |||
| `retention` | When to remove old data | `15d` | |||
There was a problem hiding this comment.
The default retention is 6h see https://github.com/aws/eks-charts/blob/master/stable/appmesh-prometheus/values.yaml#L5 Also the scrapeInterval: 5s should be added.
stefanprodan
approved these changes
Oct 25, 2019
|
@nckturner this is ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retentionneeds a mention in the table too?