Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-load-balancer-controller] allow --aws-region override #300

Merged
merged 3 commits into from
Oct 23, 2020
Merged

[aws-load-balancer-controller] allow --aws-region override #300

merged 3 commits into from
Oct 23, 2020

Conversation

dza89
Copy link
Contributor

@dza89 dza89 commented Oct 23, 2020

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dza89 dza89 changed the title add kiam support add kiam support for aws-load-balancer-controller Oct 23, 2020
@dza89 dza89 mentioned this pull request Oct 23, 2020
Closed
kishorj
kishorj reviewed Oct 23, 2020
View reviewed changes
Copy link
Contributor

@kishorj kishorj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request. I've some minor comments on the documentation.

stable/aws-load-balancer-controller/README.md Outdated Show resolved Hide resolved
stable/aws-load-balancer-controller/values.yaml Outdated Show resolved Hide resolved
@dza89
Copy link
Contributor Author

dza89 commented Oct 23, 2020

@kishorj updated per your request

@jaypipes jaypipes changed the title add kiam support for aws-load-balancer-controller [aws-load-balancer-controller] allow --aws-region override Oct 23, 2020
jaypipes
jaypipes approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@jaypipes jaypipes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the title of the PR since it's not actually specific to kiam...

@jaypipes jaypipes merged commit 96e24ed into aws:master Oct 23, 2020
@dza89
Copy link
Contributor Author

dza89 commented Oct 24, 2020

@jaypipes @kishorj

How are new charts published? If i do a helm pull eks/aws-load-balancer-controller i'm still pulling 1.0.0

@kishorj
Copy link
Contributor

kishorj commented Oct 26, 2020

@jaypipes @kishorj

How are new charts published? If i do a helm pull eks/aws-load-balancer-controller i'm still pulling 1.0.0

We release new charts periodically - whenever there are significant changes or critical fixes. New chart for eks/aws-load-balancer-controller hasn't been released since 1.0.0. We plan to release one this week.

@jellis
Copy link

jellis commented Oct 26, 2020

Conceptually, with this running in Fargate, should we also be allowing the creation of an argument to define vpc-id?

See here https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/efe7e71d270e57a70d0c17587ee89237e055ee4d/pkg/aws/cloud.go#L44

@jellis
Copy link

jellis commented Oct 26, 2020

Conceptually, with this running in Fargate, should we also be allowing the creation of an argument to define vpc-id?

See here https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/efe7e71d270e57a70d0c17587ee89237e055ee4d/pkg/aws/cloud.go#L44

Ignore that comment - I see a PR has just gone in for it #307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishorj kishorj kishorj approved these changes

@jaypipes jaypipes jaypipes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dza89 @kishorj @jellis @jaypipes