[aws-load-balancer-controller] Fix RBAC permissions on leader election role #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishorj
force-pushed
the
lb-rbac-rollback
branch
from
35eb5a2
to
e32f465
Compare
kishorj
changed the title
fawadkhaliq
reviewed
Oct 25, 2020
kishorj
force-pushed
the
lb-rbac-rollback
branch
from
e32f465
to
f50b8c4
Compare
kishorj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Undo PR #298 changes since we cannot restrict create request by resourceName. For create, this limitation is because the object name is not known at authorization time.
Tests
For further reference https://kubernetes.io/docs/reference/access-authn-authz/rbac/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.