Adding Calico Chart for AWS #50
Conversation
|
Nice! FYI you can remove all the |
mohsen0
force-pushed
the
adding-calico-chart-for-eks
branch
from
8f58701
to
ff48821
Compare
There was a problem hiding this comment.
A few things to fix up inline but overall good. Thanks very much for the PR! :)
Also, one other request... could you use rename the files in the templates/ directory to lowercase please, to be consistent with the other Helm charts in this repo?
Thanks much!
-jay
|
Ready for review |
mohsen0
force-pushed
the
adding-calico-chart-for-eks
branch
from
b8bb89d
to
ff6d29a
Compare
|
Ready for review |
|
This might be of interest to @lmm, @caseydavenport or @2ffs2nns |
|
Ready for review |
There was a problem hiding this comment.
Nicely done, @mohsen0, and thanks for the great review @stefanprodan. I'm not able to functionally test this at the moment but don't see any further issues and there is zero danger to adding this.
++ from me.
-jay
A chart for deploying Calico in AWS,
it is based on the https://docs.aws.amazon.com/eks/latest/userguide/calico.html
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.