Adding details to README about limiting machine complexity #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baldawar
reviewed
Nov 6, 2023
README.md
Outdated
| machine.addPatternRule(Integer.toString(++i), rule); | ||
|
|
||
| // Move on to the next rule. | ||
| continue ruleLoop; |
There was a problem hiding this comment.
This took a while to understand because of the goto. it might be easier to to understand if you break this into two methods, one that finds if there's a wildcard pattern present or not, and a second that does the addPatternRule here for rule.
There was a problem hiding this comment.
The goto is super cool though. But ok.
There was a problem hiding this comment.
Yup. I don't recall where you used it last time, but I found it super cool back then. 🙇
baldawar
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.