Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable wildcard imports within the package. #132

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

baldawar
Copy link
Collaborator

Issue #, if available:

Description of changes:

See https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStarImportCheck.html for more context

Rationale: Importing all classes from a package or static members from a class leads to tight coupling between packages or classes and might lead to problems when a new version of
a library introduces name clashes.

Also ran IDE-based optimize imports. Fixes a missed comment from a previous PR #129 (comment)

Benchmark / Performance (for source code changes):

N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

See https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/imports/AvoidStarImportCheck.html for more context

>  Rationale: Importing all classes from a package or static members from a class leads to tight coupling between packages or classes and might lead to problems when a new version of
a library introduces name clashes.

Also ran IDE-based optimize imports. Fixes a missed comment from a previous PR #129 (comment)
@baldawar baldawar merged commit 17860e0 into main Nov 23, 2023
3 checks passed
@baldawar baldawar deleted the avoid-imports branch November 23, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants