Making deletePatternRule a public method. #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have `addPatternRule` as public but offer no equivivalent for deleting patterns. The method is tested as part of our MachineTests.java so assuming we missed making this public in past (probably because nobody asked until #64). Benchmarks were not necessary for this change.
timbray
approved these changes
Mar 23, 2023
| @@ -593,10 +593,11 @@ public static Range between(final double bottom, final boolean openBottom, final | |||
| ``` | |||
|
|
|||
| Once you have constructed appropriate `Patterns` matchers with these methods, you can use the | |||
| following form of `Machine.addRule()` to add them to your machine: | |||
| following methods to add to or delete from your machine: | |||
There was a problem hiding this comment.
Maybe add a line saying that the cautions expressed in the description of deleteRule apply here, i.e. the patterns in the deletePatternRule call aren't required to match those in the corresponding add.
based on feedback on the pull-request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have
addPatternRuleas public but offer no equivalent for deleting patterns. The method is tested as part of our MachineTests.java so assuming we missed making this public in past (probably because nobody asked until #64).Benchmarks were not necessary for this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.