Optimize CI workflow #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baldawar
reviewed
May 9, 2023
.github/workflows/CI.yml
Outdated
| strategy: | ||
| matrix: | ||
| os: [ ubuntu-20.04 ] | ||
| java: [ 8, 11 ] |
There was a problem hiding this comment.
if its easy to add 17 as well, would love to start running builds against it.
There was a problem hiding this comment.
Sure, just take a look at the output of 11 though. IMHO there's maven warnings because the pom hardcodes to 1.8 which produces some maven warnings. I'll amend with 17 and you tell me whether that's good.
There was a problem hiding this comment.
yup. those are mostly javadoc errors which have a simple fix based on assertj/assertj#1403. I'll look into fixing it tomorrow (unless you beat me to it).
|
LGTM @embano1 . Let me know if you'd like me to merge this or hold on for JDK 17 support as well. |
baldawar
approved these changes
May 9, 2023
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
baldawar
added a commit
that referenced
this pull request
May 15, 2023
These showed up as part of #95 You can see the errors in "Verify with Maven" step in builds https://github.com/aws/event-ruler/actions/runs/4934093826/jobs/8818724018?pr=95 ``` [INFO] --- maven-compiler-plugin:3.11.0:compile (default-compile) @ event-ruler --- [INFO] Changes detected - recompiling the module! :source [INFO] Compiling 52 source files with javac [debug target 1.8] to target/classes Warning: bootstrap class path not set in conjunction with -source 8 ``` ``` Warning: Javadoc Warnings Warning: [WARNING] warning: The code being documented uses modules but the packages defined in https://docs.oracle.com/javase/8/docs/api/ are in the unnamed module. Warning: /home/runner/work/event-ruler/event-ruler/src/main/software/amazon/event/ruler/GenericMachine.java:228: warning: invalid input: '&' Warning: * @param namevals names & values which make up the rule Warning: ^ Warning: [WARNING] 2 warnings ``` This change fixes these errors. # Please enter the commit message for your changes. Lines starting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
adoptwithtemurindue to [1]matrixstrategy testing to simplify the workflow file and allow for extensibility (easily add Java and OS versions)1.8setting inpom.xml- nothing to worry, unless we want to change the configuration to avoid those)--errorsconcurrencysetting to cancel running workflows when new commits are pushed to the PR (reduce usage/resource waste){}i.e. none)[1]
Source: https://github.com/actions/setup-java
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.