fix: update generate_model_predict_response_for_dataset to use ray actors #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielezhu
force-pushed
the
js_model_runner_update
branch
from
1065479
to
29cfac5
Compare
danielezhu
changed the title
xiaoyi-cheng
previously approved these changes
Oct 11, 2023
| model.predictor = None | ||
| model.sagemaker_session = None | ||
|
|
||
| class ModelRunnerWrapper: # pragma: no cover |
There was a problem hiding this comment.
TODO: comments for context
keerthanvasist
previously approved these changes
Oct 11, 2023
danielezhu
dismissed stale reviews from keerthanvasist and xiaoyi-cheng
via
4a80c8b
xiaoyi-cheng
approved these changes
Oct 11, 2023
keerthanvasist
approved these changes
Oct 11, 2023
danielezhu
added a commit
that referenced
this pull request
Oct 11, 2023
…tors (#24) * fix: update generate_model_predict_response_for_dataset to use ray actors * fix: update actor pool strategy to use number of cpu cores instead of a static value --------- Authored-by: Daniel Zhu <daniezh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Move code that relates to Sagemaker sessions into a Ray Actor class inside generate_model_predict_response_for_dataset so that it doesn't run into issues serializing SSLContext objects (which happens if the session-creation logic is handled by the ModelRunner).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.